Repository navigation
chore(scripts): delete uncalled VM helpers, document scripts/ and release/ - #234
Merged
Merged
Conversation
…ease/ Delete scripts/test_mcp_on_vm.sh and scripts/test_a2a_through_gateway.sh: no Make target, CLI command, hook or workflow calls them, and the mcp/a2a probes of esmeralda verify (--probe <host>) cover them. The docs now point at esmeralda verify --probe and an inline curl for the raw Agent Card. Add release/README.md (what the release manifest is, who writes and reads it, how to roll back) and scripts/README.md (what each remaining script does and who calls it; new logic goes into the esmeralda CLI). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/test_mcp_on_vm.shandscripts/test_a2a_through_gateway.sh. No Make target, CLI command, git hook or workflow calls them; themcpanda2aprobes ofesmeralda verifycover them (--probe <host>limits the run to one host).esmeralda verify --probe …. The agent chapter shows an inlinecurlof the Agent Card from the test VM, andmake query … TARGET=remotefor a full A2A round trip.release/README.md:release/prd.yamlis (GitOps release manifest of image digests)esmeralda release promote), how it is reviewed (PR)env.yaml→ Layer 5 units, the running-image check,esmeralda release status)scripts/README.md: what each remaining script does and who calls it. New logic goes into theesmeraldaCLI unless it must run on the test VM.scripts/andrelease/rows.No behavior change: docs plus deletion of two scripts nothing calls. No dev test needed: no deploy, verify, build or release path is touched.
Checks:
make test,make test-guards,make docs-build(strict),esmeralda guard --diff origin/main...HEAD.