Rename Electricfieldstrength to Magneticfieldstrength #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccquigley
previously requested changes
Jan 8, 2026
Collaborator
ccquigley
left a comment
ccquigley
left a comment
There was a problem hiding this comment.
Hi Pranay, can you please add the magneticfieldstrength fields without removing electricfieldstrength?
Member
|
@ccquigley I think the removal of electricfieldstrength is intended in this PR. However, @pranay2811 I think the more correct way of making this change would be to keep the "strength" version as this is indicative of the measurement. So I would suggest removing electricfield instead and updating the units of electricfieldstrength to V/m. This shouldn't be a breaking change since no fields use either version. Additionally, please move magneticfieldstrength to the alphabetized location in the subfield file. |
shambersafai
approved these changes
Jan 13, 2026
shambersafai
requested changes
Jan 13, 2026
| offset: 0 | ||
| electriccurrentdensity: | ||
| amperes_per_square_meter: STANDARD | ||
| electricfield: |
Member
There was a problem hiding this comment.
please remove this from the subfield file as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electricfield already exists in the ontology with the unit (V/m) and magnetic field strength measures (A/m).