Make ItemName::defining_target work consistently for unsupported items#562
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Make ItemName::defining_target work consistently for unsupported items#562copybara-service[bot] wants to merge 1 commit intomainfrom
ItemName::defining_target work consistently for unsupported items#562copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_875926407
branch
from
91e0d29 to
5d508b1
Compare
Constructing an `UnsupportedItem` from an item with a defining target was throwing away context to produce an item with the same name and ID, but no defining target. This was an unintentional inconsistency and caused panics in some cases with error reporting enabled. PiperOrigin-RevId: 875926407
copybara-service
bot
force-pushed
the
test_875926407
branch
from
5d508b1 to
2381116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
ItemName::defining_targetwork consistently for unsupported itemsConstructing an
UnsupportedItemfrom an item with a defining target was throwing away context to produce an item with the same name and ID, but no defining target. This was an unintentional inconsistency and caused panics in some cases with error reporting enabled.