Move Item::defining_target to the GenericItem trait#561
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 3, 2026
Merged
Move Item::defining_target to the GenericItem trait#561copybara-service[bot] merged 1 commit intomainfrom
Item::defining_target to the GenericItem trait#561copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_875926405
branch
6 times, most recently
from
555b3b2 to
46ed870
Compare
This means adding an unused `ir` parameter to the existing calls to `Record::defining_target` to make things line up. This is meant to be a no-op in preparation for a change to the impl for `UnknownItem`, which relies on this method being in `GenericItem`. PiperOrigin-RevId: 878071539
copybara-service
bot
force-pushed
the
test_875926405
branch
from
46ed870 to
a755d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
Item::defining_targetto theGenericItemtraitThis means adding an unused
irparameter to the existing calls toRecord::defining_targetto make things line up.This is meant to be a no-op in preparation for a change to the impl for
UnknownItem, which relies on this method being inGenericItem.