This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Open
Conversation
|
Hi there, We would love to be able to use this at work, where we have a registry with a cert signed by an internal CA. Any chance this can get integrated at some point? |
|
Friendly ping. |
roblg
added a commit
to roblg/rules_docker
that referenced
this pull request
Oct 10, 2018
Work based on (and depends on) google/containerregistry#89
This was referenced Oct 10, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everybody,
I've closed this previous PR (#88) because I did not sync my fork with the upstream. So sorry for that.
this PR allows us to override cacerts that are used for all http communications, that is really useful to communicate with a private registry for example. There are already PRs about that (#39, #52) but they seem to be incomplete.
Here we basically define a new
transport.Factory()class that will be able to add custom parameters (such as ca_certs, ...), and then pass it to the underlying httplib2.Http transport.The CA can be override by using
--cacertflag. If no flag is passed, we will use the default one CA embedded with the httplib2.Example for pusher :