Skip to content

Bazel fixes for import #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnthntatum merged 1 commit into from
Mar 3, 2026
+7 −4
Merged

Bazel fixes for import #1278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ bazel_dep(
)
bazel_dep(
name = "gazelle",
version = "0.44.0",
version = "0.47.0",
repo_name = "bazel_gazelle",
)
bazel_dep(
Expand All @@ -27,13 +27,14 @@ bazel_dep(
)
bazel_dep(
name = "rules_go",
version = "0.57.0",
version = "0.59.0",
repo_name = "io_bazel_rules_go",
)
bazel_dep(
name = "rules_proto",
version = "7.0.2",
)
bazel_dep(name = "rules_shell", version = "0.6.1")

# local_path_override(
# module_name = "cel-spec",
Expand Down
6 changes: 4 additions & 2 deletions conformance/conformance_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
This module contains build rules for generating the conformance test targets.
"""

load("@rules_shell//shell:sh_test.bzl", "sh_test")

# Converts the list of tests to skip from the format used by the original Go test runner to a single
# flag value where each test is separated by a comma. It also performs expansion, for example
# `foo/bar,baz` becomes two entries which are `foo/bar` and `foo/baz`.
Expand All @@ -38,13 +40,13 @@ def _expand_tests_to_skip(tests_to_skip):
def _conformance_test_args(data, skip_tests, dashboard):
args = []
args.append("--skip_tests={}".format(",".join(_expand_tests_to_skip(skip_tests))))
args.append("--tests={}".format(",".join(["$(location " + test + ")" for test in data])))
args.append("--tests={}".format(",".join(["$(rlocationpath " + test + ")" for test in data])))
if dashboard:
args.append("--dashboard")
return args

def conformance_test(name, data, dashboard, skip_tests = []):
native.sh_test(
sh_test(
name = name,
size = "small",
srcs = ["//conformance:conformance_test.sh"],
Expand Down