-
Notifications
You must be signed in to change notification settings - Fork 41
Document running samples like gltf_basic_materials #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
footballhead
wants to merge
4
commits into
google:main
Choose a base branch
from
footballhead:document_gltf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # gltf_basic_materials | ||
|
footballhead marked this conversation as resolved.
|
||
|
|
||
| This sample loads a scene with `ppx::scene::GltfLoader` and renders it. | ||
|
|
||
| After building, run `gltf_basic_materials` for the desired API in your build directory. E.g. for Vulkan: | ||
|
|
||
| ```sh | ||
| vk_gltf_basic_materials | ||
| ``` | ||
|
|
||
| By default, this will load `//assets/scene_renderer/scenes/tests/gltf_test_basic_materials.glb`. You can change which scene to load using the `--gltf-scene-asset` option: | ||
|
|
||
| ```sh | ||
| vk_gltf_basic_materials --gltf-scene-asset basic/models/altimeter/altimeter.gltf | ||
| ``` | ||
|
|
||
| This loads and renders `//assets/basic/models/altimeter/altimeter.gltf`. Notice that the provided path must be relative to one of the following directories: | ||
|
|
||
| * `//assets/` | ||
| * `//third_party/assets/` | ||
| * Any path provided via `--extra-assets-path` | ||
|
|
||
| ## glTF-Sample-Assets | ||
|
|
||
| Since BigWheels does not provide many glTF scenes, it is recommended to test changes against [KhronosGroup/gltf-Sample-Assets](https://github.com/KhronosGroup/glTF-Sample-Assets). | ||
|
|
||
| First, clone the repository. This does not have to be in the BigWheels checkout: | ||
|
|
||
| ```sh | ||
| git clone https://github.com/KhronosGroup/glTF-Sample-Assets | ||
| ``` | ||
|
|
||
| Second, run `gltf_basic_materials` with the desired scene. | ||
|
|
||
| ```sh | ||
| vk_gltf_basic_materials --gltf-scene-asset Box/glTF/Box.gltf --extra-assets-path some/path/to/glTF-Sample-Assets/Models | ||
| ``` | ||
|
|
||
| Notice that we provide: | ||
|
|
||
| * `--extra-assets-path` which points to the `Models` directory in the location of the glTF-Sample-Assets clone | ||
| * `--gltf-scene-asset` to load the Box model. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Scene Graph | ||
|
|
||
| This directory contains implementations for scene graph loading and rendering. | ||
|
|
||
| Of note is the `GltfLoader` class in `scene_gltf_loader.cpp`. This class can parse a `.gltf` file and return a renderable `Scene`. | ||
|
|
||
| To test changes to this implementation, run the `gltf_basic_materials` sample in `//projects/gltf_basic_materials`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.