fix: resolve Ruff violations in playground/backend_manager - #67
Open
swadhinbiswas wants to merge 1 commit into
Open
swadhinbiswas wants to merge 1 commit into
swadhinbiswas wants to merge 1 commit into
Conversation
Modernize datetime/typing usage in playground/backend_manager so CI's `ruff check .` and `ruff format --check .` pass: - datetime.now(timezone.utc) -> datetime.now(UTC) - Optional["X"] -> X | None - drop now-unused timezone/Optional/datetime imports
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Uzzoper
added a commit
to Uzzoper/artemis
that referenced
this pull request
Sep 26, 2026
…d_manager Mechanical ruff check --fix plus format for the 11 errors keeping python-quality red on main (same as stalled google#30/google#67). Split out from the google#129 feature for scope discipline.
|
Heads-up: #155 (fix for #129) had to include the same mechanical ruff fix for playground/backend_manager as a separate commit, because main's python-quality is red without it. Your PR was first — if it merges first, I'll gladly drop ours in a rebase and keep #155 to the feature only. Flagging so maintainers can treat whichever lands first as canonical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI
Lint Pythonfailure onmain:uv run ruff check .reports 11 errors inplayground/backend_manager.UP017: use thedatetime.UTCalias instead oftimezone.utcUP045/UP037: useX | Noneinstead ofOptional["X"]timezone,Optional, anddatetimeimportsFiles changed
playground/backend_manager/app/auth/jwt_handler.pyplayground/backend_manager/app/auth/otp_service.pyplayground/backend_manager/app/services/session_manager.pyplayground/backend_manager/app/services/bigquery_service.pyplayground/backend_manager/app/services/docker_service.pyVerification
uv run ruff check .→ All checks passeduv run ruff format --check .→ 616 files already formatted