Skip to content

fix(runtime): stop the Windows daemon from opening a visible console #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Silversun31 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runtime): stop the Windows daemon from opening a visible console #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions artemis/runtime/daemon_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,7 @@ def spawn_daemon(
}

if sys.platform == "win32":
kwargs["creationflags"] = (
subprocess.CREATE_NEW_PROCESS_GROUP
| getattr(subprocess, "DETACHED_PROCESS", 0x00000008)
| getattr(subprocess, "CREATE_NO_WINDOW", 0x08000000)
)
kwargs["creationflags"] = subprocess.CREATE_NEW_PROCESS_GROUP | subprocess.CREATE_NO_WINDOW
else:
kwargs["start_new_session"] = True

Expand Down
5 changes: 5 additions & 0 deletions tests/unit/runtime/test_daemon_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def test_is_daemon_running_failure():


def test_spawn_daemon(tmp_path):
import subprocess
import sys

mock_proc = MagicMock()
Expand All @@ -74,6 +75,10 @@ def test_spawn_daemon(tmp_path):
assert cmd[0] == sys.executable
assert cmd[1:3] == ["-m", "apps.admin_console.server"]
assert cmd[3:] == ["--host", "127.0.0.1", "--port", "9123"]
if sys.platform == "win32":
assert mock_popen.call_args.kwargs["creationflags"] == (
subprocess.CREATE_NEW_PROCESS_GROUP | subprocess.CREATE_NO_WINDOW
)


def test_ensure_daemon_running_when_already_active():
Expand Down
Loading