Conversation
get_llm was called without is_utils=True, so the lookup always raised and was silently caught, making detection run on the operator model instead of the configured utils.object_detector model. Log a warning when falling back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157
Summary
_run_object_detectioncalledget_llm(ctx, name="object_detector")withoutis_utils=True. Sinceobject_detectoris a utils node, the lookup always raisedAttributeError, which was silently caught, so detection ran on the operator model instead of the configuredutils.object_detectormodel (gemini-robotics-er-2-previewin the stock config).Changes
artemis/agents/object_detector/object_detector.py: passis_utils=True, and log a warning when falling back to the operator model so the fallback is no longer silent.tests/unit/agents/test_object_detector_model_resolution.py: two testsname="object_detector", is_utils=Trueand uses that modelVerification
main(2 failed) and pass with the fix. They mockget_llm, so no API key is needed.config/artemis.jsonc:gemini-3.8-flash(operator)gemini-robotics-er-2-previewtests/tools/inputs/screenshot.jpg: the request went togemini-robotics-er-2-previewand returned a point for the date input field of[428, 196](0-1000 scale), matching its on-screen position (~[422, 196]).test_awake_service.py::test_discovery_keeps_only_pool_claimed_devices), with passed count 2186 → 2188 (the two new tests).ruff format --check,ruff check(changed files),scripts/quality_ratchet.py(754 / 0 / 18, unchanged), andpyright --project pyright-core.jsonare clean.Note
Other utils nodes (
hopper,outputter) already passis_utils=True; this was the only call missing it.