Add the NOTICE file Apache 2.0 section 4(d) requires - #150
Open
basil-k-aji-dev wants to merge 1 commit into
Open
basil-k-aji-dev wants to merge 1 commit into
basil-k-aji-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Why
ARTEMIS is Apache-2.0 and includes source developed by Minitap, Inc. from mobile-use, which is also Apache-2.0 and ships a
NOTICEfile. Section 4(d) says that where the original work includes aNOTICE, a redistribution must carry a readable copy of the attribution notices it contains. This repository has aLICENSEand noNOTICE, so those notices are not being carried forward.Verified rather than assumed, since the whole obligation hinges on the upstream file existing:
The README already credits Minitap, and the source headers already carry
Copyright 2025-2026 Minitap, Inc.. Both are good, and neither is the thing 4(d) asks for: it wants the contents of the upstreamNOTICE, which includes an attribution request that appears nowhere in this repository today.What
A root
NOTICEcarrying ARTEMIS's own copyright line, a statement of the inclusion, and the upstream notices reproduced verbatim below a separator. Reproduced without edits, because 4(d) asks for a readable copy of what the file says, not a summary of it. The upstream attribution request travels with it, which also satisfies the thing Minitap actually asked for.One line added to the README's License section pointing at the file, so a reader who starts there can find it.
Testing
Nothing executable changed, so
make testhas nothing to exercise here and I have not claimed a run. What I did check is that no packaging or build config referencesLICENSEin a way a siblingNOTICEwould need adding to;pyproject.tomlmentions it only inside its own license header comment, and there is noMANIFEST.in.If ARTEMIS ships wheels or images where the license file is copied in by an explicit path,
NOTICEshould ride along with it, and I am happy to add that here if you point me at the spot.Note
I am not a lawyer and this is not legal advice. The claim in the issue is checkable and I checked it; whether Google wants this exact wording is yours to decide, and I will take any rewrite of the header lines without argument. The reproduced block below the separator should stay byte-identical to upstream.