Skip to content

webrtc: Add Sound volume and mute controls support#2213

Open
thjnk wants to merge 1 commit intogoogle:mainfrom
thjnk:main
Open

webrtc: Add Sound volume and mute controls support#2213
thjnk wants to merge 1 commit intogoogle:mainfrom
thjnk:main

Conversation

@thjnk
Copy link
Contributor

@thjnk thjnk commented Mar 3, 2026

This change implements volume and mute controls for the WebRTC audio backend in Cuttlefish. These controls allow the guest to dynamically adjust playback and capture audio levels via Virtio Sound control messages.

  • AudioMixer: Apply playback volume scaling during audio stream resampling by modifying the channel mix map.
  • Implement read/write logic for Virtio audio volume/mute control commands.
  • Guest Config: Allow enabling of Virtio Sound controls per stream.

@jemoreira jemoreira self-requested a review March 3, 2026 19:02
@thjnk thjnk force-pushed the main branch 3 times, most recently from 3400ea9 to 74ccc5d Compare March 4, 2026 14:11
@jemoreira
Copy link
Member

The three bullet points in the PR description sound like they should be different commits. That would make the PR much easier to review.

@thjnk thjnk marked this pull request as ready for review March 5, 2026 13:18
@Databean Databean self-requested a review March 17, 2026 22:20
@Databean Databean added the kokoro:run Run e2e tests. label Mar 17, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 17, 2026
@thjnk thjnk force-pushed the main branch 2 times, most recently from b94b9cd to cc5b953 Compare March 18, 2026 15:17
@Databean Databean added the kokoro:run Run e2e tests. label Mar 18, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 18, 2026
This change implements volume and mute controls for the WebRTC audio
backend in Cuttlefish. These controls allow the guest to dynamically
adjust playback and capture audio levels via Virtio Sound control messages.

- AudioMixer: Apply playback volume scaling during audio stream
  resampling by modifying the channel mix map.
- Implement read/write logic for Virtio audio volume/mute control commands.
- Guest Config: Allow enabling of Virtio Sound controls per stream.
@Databean Databean added the kokoro:run Run e2e tests. label Mar 19, 2026
@Databean Databean enabled auto-merge March 19, 2026 09:52
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 19, 2026
@Databean Databean added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Mar 19, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Mar 19, 2026
@Databean Databean added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants