fix(models): Drop stale thought signatures#6202
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Response from ADK Triaging Agent Hello @its-amann, thank you for creating this PR! It looks like your Contributor License Agreement (CLA) check is currently failing. Please sign the Google CLA at https://cla.developers.google.com/ to proceed. Once the CLA is signed, we can move forward with triaging and labeling your PR. Thank you! |
20988cd to
9b7b669
Compare
Keep only the newest thought_signature in request contents so prior turns do not send signatures the model no longer uses. Fixes google#3693
02e525b to
a4a9d37
Compare
|
Hi @its-amann , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @GWeale , can you please review this. |
Fixes #3693
Summary
thought_signaturein outgoing request contents.Testing
uv run --extra dev pyink src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.pyuv run --extra dev ruff check src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.pyuv run python -m pytest tests\unittests\models\test_google_llm.py::test_generate_content_async_keeps_only_latest_thought_signatureuv run python -m pytest tests\unittests\models\test_google_llm.py::test_generate_content_async_keeps_only_latest_thought_signature tests\unittests\models\test_google_llm.py::test_generate_content_async tests\unittests\models\test_google_llm.py::test_generate_content_async_stream tests\unittests\models\test_google_llm.py::test_generate_content_async_stream_preserves_thinking_and_text_parts