fix(LiteLlm): recognize assistant- prefix as valid OpenAI file ID#6154
Merged
Conversation
Merge #5758 Original PR by @nileshpatil6 (Nilesh Patil <128893479+nileshpatil6@users.noreply.github.com>) Azure OpenAI files receive IDs with an `assistant-` prefix (e.g. `assistant-abc123`) or `file-` prefix. When `_looks_like_openai_file_id` recognizes an `assistant-` prefixed ID (e.g., `assistant-abc123`) or `file-` prefixed ID, `_redact_file_uri_for_log` defaulted to logging both as `file - <redacted>`. Fix: refactor `_redact_file_uri_for_log` to dynamically extract file ID prefixes (`file-`, `assistant-`). This ensures compatibility with both current prefixes and future OpenAI/Azure file ID types. Fixes #5664 Co-authored-by: Yi Liu <yiliuly@google.com> PiperOrigin-RevId: 933931477
copybara-service
Bot
force-pushed
the
copybara/933543436
branch
from
fcf187a to
ea325c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(LiteLlm): recognize assistant- prefix as valid OpenAI file ID
Merge #5758
Original PR by @nileshpatil6 (Nilesh Patil 128893479+nileshpatil6@users.noreply.github.com)
Azure OpenAI files receive IDs with an
assistant-prefix (e.g.assistant-abc123) orfile-prefix. When_looks_like_openai_file_idrecognizes anassistant-prefixed ID (e.g.,assistant-abc123) orfile-prefixed ID,_redact_file_uri_for_logdefaulted to logging both asfile - <redacted>.Fix: refactor
_redact_file_uri_for_logto dynamically extract file ID prefixes (file-,assistant-). This ensures compatibility with both current prefixes and future OpenAI/Azure file ID types.Fixes #5664
Co-authored-by: Yi Liu yiliuly@google.com