Skip to content

fix: remove live event buffering in runner#6151

Merged
wuliang229 merged 2 commits into
v1from
v1-event-buffer
Jun 17, 2026
Merged

fix: remove live event buffering in runner#6151
wuliang229 merged 2 commits into
v1from
v1-event-buffer

Conversation

@wuliang229

Copy link
Copy Markdown
Collaborator

Keep the ADK events in their original order as they arrive. In the original code, if the output transcriptions are long, the function call and response events are only appended at the very end of transcription. If any downstream program consumes the events, they are in the wrong order.

@wuliang229 wuliang229 requested a review from wukath June 17, 2026 19:59
@adk-bot adk-bot added the live [Component] This issue is related to live, voice and video chat label Jun 17, 2026
@adk-bot

adk-bot commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Response from ADK Triaging Agent

Hello @wuliang229, thank you for creating this PR!

To help us review your PR more efficiently and ensure it aligns with our contribution guidelines, could you please update the PR description to include the following:

  1. Testing Plan: Please include a testing plan section describing how you tested these changes (e.g., unit tests run or manual E2E verification).
  2. Logs or Screenshots: Since this is a bug fix related to event ordering in the runner, providing logs or a screenshot showing the correct event sequence after applying the fix would be extremely helpful.
  3. Issue Association: If there is an associated GitHub issue for this fix, please reference/link it in the PR description.

For more details on these requirements, please consult our Contribution Guidelines.

Thank you!

@wuliang229 wuliang229 marked this pull request as draft June 17, 2026 20:02
@wuliang229 wuliang229 changed the base branch from main to v1 June 17, 2026 20:03
@wuliang229 wuliang229 marked this pull request as ready for review June 17, 2026 20:03
@wyf7107 wyf7107 assigned wyf7107 and unassigned wyf7107 Jun 17, 2026
@wuliang229 wuliang229 merged commit afe4083 into v1 Jun 17, 2026
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live [Component] This issue is related to live, voice and video chat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants