Skip to content

feat(bigtable): Support parameterized views with secure parameter inj…#6128

Open
ad548 wants to merge 4 commits into
google:mainfrom
ad548:feat/bigtable-parameterized-views
Open

feat(bigtable): Support parameterized views with secure parameter inj…#6128
ad548 wants to merge 4 commits into
google:mainfrom
ad548:feat/bigtable-parameterized-views

Conversation

@ad548

@ad548 ad548 commented Jun 15, 2026

Copy link
Copy Markdown

…ection

Expose a parameterized query tool execute_sql_parameterized that automatically maps and injects secure parameters (like user_id) from the tool context to Bigtable's view_parameters.

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

ad548 added 2 commits June 15, 2026 13:24
…ection

Expose a parameterized query tool execute_sql_parameterized that automatically maps and injects secure parameters (like user_id) from the tool context to Bigtable's view_parameters.
If the configured view_parameter_name is not a top-level property on the ToolContext (like user_id), check tool_context.state to support arbitrary application-specific session parameters (e.g. tenant_id).
@rohityan rohityan self-assigned this Jun 15, 2026
@wyf7107 wyf7107 self-assigned this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants