Skip to content

Function Declaration error caused by None, returning schema error - O…#5557

Closed
Chris-Jones-Qodea wants to merge 5 commits into
google:mainfrom
Chris-Jones-Qodea:main
Closed

Function Declaration error caused by None, returning schema error - O…#5557
Chris-Jones-Qodea wants to merge 5 commits into
google:mainfrom
Chris-Jones-Qodea:main

Conversation

@Chris-Jones-Qodea

Copy link
Copy Markdown

…ptional usage fix

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Problem:
Unable to submit request because search_catalog functionDeclaration parameters.project_ids_filter schema didn't specify the schema type field.

None attributes fail on tool registration.

Solution:
Use optionals, for example:
Optional[list[str]] = None,

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Manual End-to-End (E2E) Tests:

Working

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@adk-bot

adk-bot commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Response from ADK Triaging Agent

Hello @Chris-Jones-Qodea, thank you for creating this PR!

This PR is a bug fix, could you please provide logs or screenshot after the fix is applied?

This information will help reviewers to review your PR more efficiently. Thanks!

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Apr 30, 2026
@rohityan rohityan self-assigned this Apr 30, 2026
@rohityan

rohityan commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Hi @Chris-Jones-Qodea , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh

@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label May 8, 2026
@GWeale GWeale self-requested a review June 16, 2026 23:33
@GWeale GWeale self-assigned this Jun 17, 2026
@GWeale

GWeale commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks for looking into this! tools/bigquery/search_tool.py has since moved to integrations/bigquery/search_tool.py (the old path is now just a deprecation shim), and the relocated search_catalog already declares those parameters as optionals, so there's nothing left to change here. Closing as already resolved; also a heads-up that the linked #3228 is about .env loading and unrelated to this change.

@GWeale GWeale closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request clarification [Status] The maintainer need clarification or more information from the author tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable forced .env loading

4 participants