Fix dtype of empty feature shuffle patterns#73
Open
Echo-Nie wants to merge 1 commit into
Open
Conversation
Echo-Nie
requested review from
abhidas,
erzel,
rajatsen91,
siriuz42,
tamannarayan and
weihaokong
as code owners
July 20, 2026 02:09
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
The PR is ready to be reviewed, thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Thx for open-sourcing TabFM — really appreciate the work!
While running TabFM on the KC1 dataset with an n-shot retrieved context,
predict_probacrashes with:The relevant traceback is:
The shuffle patterns are converted with:
When
pis empty, NumPy infersfloat64. The resulting array is later used for column indexing, which requires an integer or boolean dtype.Fix
Convert shuffle patterns using NumPy's native indexing dtype:
This preserves the values and ordering of non-empty patterns while making empty patterns valid NumPy index arrays.
Reproduce
After this change:
Test
Ran the existing classifier and regressor tests: