Fix minimum Python version in README (3.11) - #364
Open
rishabhsai wants to merge 1 commit into
Open
rishabhsai wants to merge 1 commit into
rishabhsai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "From Source" section of README.md says "Requires Python 3.10 or later", but the floor is 3.11: pyproject.toml line 12 has
requires-python = ">=3.11", the classifiers list only 3.11 and 3.12, and the CI matrix in .github/workflows/ci.yml is["3.11", "3.12"]. The requirement was raised in d43c721 and the README line was missed, so a reader on 3.10 follows the install steps and gets refused by the resolver. Changed the line to 3.11; checked withgrep -n "Requires Python" README.mdagainstgrep -n requires-python pyproject.toml.