Skip to content

Fix vision notebook links and RSL-RL log path in learning README - #363

Open
rishabhsai wants to merge 1 commit into
google-deepmind:mainfrom
rishabhsai:docs-learning-readme-vision-notebook-and-rsl-rl-logs
Open

rishabhsai wants to merge 1 commit into
google-deepmind:mainfrom
rishabhsai:docs-learning-readme-vision-notebook-and-rsl-rl-logs

Conversation

@rishabhsai

Copy link
Copy Markdown

The two Colab links at the bottom of the tutorial list in learning/README.md are dead. They point at learning/notebooks/training_vision_1.ipynb and training_vision_2.ipynb, which were deleted in 903fcd7 and replaced with the single learning/notebooks/vision.ipynb; that commit updated the notebook table in the top-level README but not this file, so both links have returned 404 since. The RSL-RL section also said logs and checkpoints go to a logs directory, which is true of train_jax_ppo.py but not of train_rsl_rl.py, where line 144 builds logdir from /tmp/rslrl-training-logs/ plus the experiment name and line 213 resolves --load_run_name against the same prefix. I replaced the two dead items with one "Vision Environments" item using the top-level README's wording, renumbered, and corrected the log path sentence; curl -sIL returns 200 for vision.ipynb and 404 for both training_vision_*.ipynb, and grep -n training_vision learning/README.md is now empty.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant