Fix vision notebook links and RSL-RL log path in learning README - #363
Open
rishabhsai wants to merge 1 commit into
Open
rishabhsai wants to merge 1 commit into
rishabhsai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two Colab links at the bottom of the tutorial list in learning/README.md are dead. They point at learning/notebooks/training_vision_1.ipynb and training_vision_2.ipynb, which were deleted in 903fcd7 and replaced with the single learning/notebooks/vision.ipynb; that commit updated the notebook table in the top-level README but not this file, so both links have returned 404 since. The RSL-RL section also said logs and checkpoints go to a
logsdirectory, which is true of train_jax_ppo.py but not of train_rsl_rl.py, where line 144 buildslogdirfrom/tmp/rslrl-training-logs/plus the experiment name and line 213 resolves--load_run_nameagainst the same prefix. I replaced the two dead items with one "Vision Environments" item using the top-level README's wording, renumbered, and corrected the log path sentence;curl -sILreturns 200 for vision.ipynb and 404 for both training_vision_*.ipynb, andgrep -n training_vision learning/README.mdis now empty.