Fix G1 RSL-RL config to use the registered environment name - #355
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsl_rl_config()applies a tunedmax_iterations=1000schedule to several locomotion tasks, but the G1 entry is currentlyG1Joystick, which is not a registered MuJoCo Playground environment. The registered flat-terrain task isG1JoystickFlatTerrain, so that task misses the intended RSL-RL schedule and keeps the defaultmax_iterations=100000.This change:
G1Joystickconfig key with the registeredG1JoystickFlatTerrainname;max_iterations=1000.Validation
76f5e8887445b4921b1ba91af50722ba6bcb4e66.mainate74217bb89c77a74ba02e4789263991864375799.