This repository was archived by the owner on Jul 17, 2026. It is now read-only.
fix(pd-lm): SIGPIPE-proof the driver-version detection in the node-setup script#990
Closed
claude-spd1 wants to merge 1 commit into
Closed
fix(pd-lm): SIGPIPE-proof the driver-version detection in the node-setup script#990claude-spd1 wants to merge 1 commit into
claude-spd1 wants to merge 1 commit into
Conversation
…tup script nvidia-smi --query-gpu writes one line per GPU; '| head -n 1' closes the pipe after the first, and under 'set -o pipefail' a late write from nvidia-smi turns into SIGPIPE -> exit 141, killing the whole srun step before the workspace even builds. Racy per node: observed three times across 1- and 4-node submissions (jobs 1050555, 1050877 requeue, 1090526). Query GPU 0 alone instead — 'cut' consumes the full stream, no pipe truncation, same DRIVER_MAJOR. Crew-Address: task/scan-read-activations-taps
Collaborator
Author
|
Duplicate of #984 (same one-line --id=0 fix, opened earlier and verified with a 300-iteration repro: 57/300 failures unpatched, 0/300 patched — see task workspace-fetch-sigpipe-flake and lore:2026-07-15--finding--pd-lm-setup-sigpipe-nvidia-smi-race). Closing in favor of #984. For what it's worth this PR's three independent hits (jobs 1050555, 1050877's requeue, 1090526 — 1- and 4-node submissions on cw-rno2) are further field confirmation of the diagnosis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The generated sbatch node-setup script detects the CUDA extra via
nvidia-smi --query-gpu=driver_version --format=csv,noheader | head -n 1 | cut -d. -f1.nvidia-smiwrites one line per GPU;head -n 1closes the pipe after the first line, and under the script'sset -o pipefaila late write from nvidia-smi becomes SIGPIPE → exit 141, killing the whole srun step before the workspace even builds. It's a per-node race — observed three times across 1- and 4-node submissions (jobs 1050555, 1050877's requeue, 1090526), and with N nodes per job the odds multiply.Fix: query GPU 0 alone (
nvidia-smi --id=0 ...) —cutconsumes the full stream, no mid-stream pipe close, sameDRIVER_MAJOR.Motivation and Context
Flaky launch failures burn queue time (an opportunistic 4-node allocation dies in 5s and goes back to the end of the line) and look like real breakage.
How Has This Been Tested?
Patched the submitting checkout and resubmitted the same 4-node probes; generated scripts carry the new line.
nvidia-smi --id=0 --query-gpu=driver_version --format=csv,noheaderverified to emit exactly one line on an 8-GPU node.Does this PR introduce a breaking change?
No — submit-side script generation only.
🤖 Generated with Claude Code
Crew-Address: task/scan-read-activations-taps