Use the reference environment's uv.lock#2
Open
maxsloef-goodfire wants to merge 5 commits into
Open
Conversation
The midtraining repo's prepare_olmes_venv.sh runs `uv sync --group gpu --frozen` in this checkout, but uv.lock was gitignored and never committed, so the lockfile only existed in the original author's working copy and every fresh clone failed with "Unable to find lockfile at uv.lock". Track uv.lock (resolved 2026-06-11 against the pinned pyproject: lm_eval==0.4.3, vllm==0.11.0, torch 2.8.0+cu128) and drop it from .gitignore so the eval environment is reproducible from a clean bootstrap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Commit uv.lock so prepare_olmes_venv.sh works on fresh clones
Replace the freshly-resolved lockfile with the one from the validated eval environment (sha256 22cb1f78..., uv 0.11.16). The two differed only in 16 transitive patch-level versions; all direct pins (lm_eval==0.4.3, vllm==0.11.0, torch 2.8.0+cu128) are identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1, which you merged before my second commit landed on the branch (fast review! 🏃): this swaps in the uv.lock from your validated environment (sha256
22cb1f78…, uv 0.11.16) in place of my fresh resolution. Same direct pins; 16 transitive patch-level versions differ. Verified: venv rebuilt from this lock, vllm/lm_eval/torch import and run evals.🤖 Generated with Claude Code