Repository navigation
rust: ship rustdoc again (list it in bootstrap.toml tools) - #887
Closed
bryan-minimal wants to merge 1 commit into
Closed
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
#667 set build.tools to drop the offline-hostile `src` step, and the list left rustdoc out. With `tools` set, dist::Rustc copies the rustdoc binary only when the list names it, so every rust since d0b0026 ships without rustdoc and `cargo test` fails on doctests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #667 (d0b0026, 2026-09-24) the rust package ships no
rustdoc. The current world's rust artifact (1b13bbd7…, spec8cefa3f0…) hascargo cargo-clippy cargo-fmt clippy-driver rust-analyzer rust-gdb rust-lldb rustc rustfmtinusr/bin, and nothing else.Why: #667 set
tools = ["cargo", "clippy", "rustfmt", "rust-analyzer"]inbootstrap.toml(to keep the offline-hostilesrcstep out). In Rust 1.98.1's bootstrap,dist::Rustc::prepare_imagecopies rustdoc only whenbuild.toolsis unset or lists"rustdoc":and
x.py install compiler/rustcinstalls exactly that dist image. Before #667toolswas unset, so rustdoc shipped.Effect: any
cargo testthat reaches doctests fails withcould not execute process `rustdoc` … No such file or directory. Found moving build-servers to minimal main (gominimal/build-servers#373, which holds its pkgs pin at d5e98b3, #667's parent, until this lands).Fix: add
"rustdoc"to the list. Nothing else changes.Cost: this changes rust's spec hash, so rust and everything built with it rebuild. Worth timing deliberately.
🤖 Generated with Claude Code
Summary by CodeRabbit