Skip to content

Update grpc to 1.84.0 - #845

Merged
bryan-minimal merged 4 commits into
mainfrom
update-grpc-1.84.0
Oct 19, 2026
Merged

bryan-minimal merged 4 commits into
mainfrom
update-grpc-1.84.0

Conversation

@gominimal-pkgmgr-mgr

Copy link
Copy Markdown
Contributor

Update grpc 1.83.1 → 1.84.0

Source: github:grpc/grpc
Release: https://github.com/grpc/grpc/releases/tag/v1.84.0
Changelog: grpc/grpc@v1.83.1...v1.84.0
Released: 28 days ago (2026-09-11)

Pkgscan: clean — diff against the prior version surfaced no newly-introduced suspicious patterns.

Components changed

CycloneDX component delta (declared materials — the package's own version, not a dependency-tree diff)
Component Old New
~ grpc 1.83.1 1.84.0
~ grpc-upstream 1.83.1 1.84.0

Changes

Old New
Version 1.83.1 1.84.0
SHA256 60caa8397426d8a5... 17a4d25717f4871e...
Size 16.4 MB
Source https://github.com/grpc/grpc/archive/refs/tags/v1.83.1.tar.gz https://github.com/grpc/grpc/archive/refs/tags/v1.84.0.tar.gz
  • License: Apache-2.0 (source: GitHub)

Created by pkgmgr

@gominimal-pkgmgr-mgr
gominimal-pkgmgr-mgr Bot requested a review from a team as a code owner October 9, 2026 05:48
@gominimal-pkgmgr-mgr gominimal-pkgmgr-mgr Bot added auto-update Opened autonomously by pkgmgr auto-update auto-update-leaf Freshness-only bump of a true leaf package; clears no advisory labels Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: gominimal/pkgs/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 14642a70-e354-4a61-94d2-7f21fc843077

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mitodrummer mitodrummer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimal build fails on both arches because grpc 1.84.0 adds third_party/grpc-proto as a new git submodule (url github.com/grpc/grpc-proto, pinned at ec30f589e2519d595688b9a42f88a91bdd6b733f), and GitHub's archive tarball leaves submodule directories empty, so CMake can't find third_party/grpc-proto/grpc/reflection/v1/reflection.proto. The bump can't merge as-is. Add a second Source for grpc/grpc-proto at that commit and place it at third_party/grpc-proto before configure (or in build.sh), then re-run the build.

bryan-minimal and others added 2 commits October 15, 2026 17:33
1.84.0 added third_party/grpc-proto as a git submodule; the GitHub tag
archive leaves it empty, so CMake can't find
grpc/reflection/v1/reflection.proto and the build fails on both arches.

Add grpc/grpc-proto at the submodule's pinned commit (ec30f589, verified
with `git ls-tree v1.84.0 third_party/grpc-proto`) as a second Source,
using the archive URL and sha256 grpc's own CMakeLists.txt records for it,
and unpack it into place in build.sh with a fail-closed check for the
proto CMake needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal

Copy link
Copy Markdown
Member

@mitodrummer thanks, that diagnosis was spot on. Fixed in 2a09671, as you suggested:

  • build.ncl: a second Source for grpc/grpc-proto at ec30f589e2519d595688b9a42f88a91bdd6b733f, the commit git ls-tree v1.84.0 third_party/grpc-proto points the submodule to. The sha256 is the one grpc's own CMakeLists.txt records for that archive.
  • build.sh: unpacks it into third_party/grpc-proto before configure, then fails closed with test -f third_party/grpc-proto/grpc/reflection/v1/reflection.proto.

It's green on both arches now (minimal build and minimal-check, plus closure and the report checks). The last commit, 36a274c, is only a no-op to rebuild against current main.

One follow-up for the next bump: pkgmgr's updater rewrites only the first sha256, so the grpc-proto pin won't move on its own. The build.ncl comment says to re-check it on every bump.

Could you take another look?

@bryan-minimal
bryan-minimal added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit cd611d8 Oct 19, 2026
11 checks passed
@bryan-minimal
bryan-minimal deleted the update-grpc-1.84.0 branch October 19, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Opened autonomously by pkgmgr auto-update auto-update-leaf Freshness-only bump of a true leaf package; clears no advisory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants