Repository navigation
Update grpc to 1.84.0 - #845
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
mitodrummer
left a comment
There was a problem hiding this comment.
The minimal build fails on both arches because grpc 1.84.0 adds third_party/grpc-proto as a new git submodule (url github.com/grpc/grpc-proto, pinned at ec30f589e2519d595688b9a42f88a91bdd6b733f), and GitHub's archive tarball leaves submodule directories empty, so CMake can't find third_party/grpc-proto/grpc/reflection/v1/reflection.proto. The bump can't merge as-is. Add a second Source for grpc/grpc-proto at that commit and place it at third_party/grpc-proto before configure (or in build.sh), then re-run the build.
1.84.0 added third_party/grpc-proto as a git submodule; the GitHub tag archive leaves it empty, so CMake can't find grpc/reflection/v1/reflection.proto and the build fails on both arches. Add grpc/grpc-proto at the submodule's pinned commit (ec30f589, verified with `git ls-tree v1.84.0 third_party/grpc-proto`) as a second Source, using the archive URL and sha256 grpc's own CMakeLists.txt records for it, and unpack it into place in build.sh with a fail-closed check for the proto CMake needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@mitodrummer thanks, that diagnosis was spot on. Fixed in 2a09671, as you suggested:
It's green on both arches now ( One follow-up for the next bump: pkgmgr's updater rewrites only the first sha256, so the grpc-proto pin won't move on its own. The build.ncl comment says to re-check it on every bump. Could you take another look? |
Update grpc
1.83.1→1.84.0Source:
github:grpc/grpcRelease: https://github.com/grpc/grpc/releases/tag/v1.84.0
Changelog: grpc/grpc@v1.83.1...v1.84.0
Released: 28 days ago (2026-09-11)
Components changed
CycloneDX component delta (declared materials — the package's own version, not a dependency-tree diff)
grpc1.83.11.84.0grpc-upstream1.83.11.84.0Changes
1.83.11.84.060caa8397426d8a5...17a4d25717f4871e...https://github.com/grpc/grpc/archive/refs/tags/v1.83.1.tar.gzhttps://github.com/grpc/grpc/archive/refs/tags/v1.84.0.tar.gzApache-2.0(source: GitHub)Created by pkgmgr