Repository navigation
ladder rungs: pkgmgr bootstrap_rung freeze markers (comment-only, no rebuild) - #776
Merged
Merged
Conversation
One comment line per frozen bootstrap rung already on main (39): hex0/stage0/ bedrock -> "hex0", go-1.x chain -> "go", mrustc..rustc-1.97.1 -> "rust". Read by pkgmgr (pkgmgr-rs#904/#907) to freeze the rung; comments are not evaluated and not in the spec hash, so nothing rebuilds. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: gominimal/pkgs/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (39)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughPackage build specifications add ChangesBootstrap metadata
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The annotations do not change the checked-in build specifications. The external consumer’s handling could not be confirmed, but no concrete regression is established, so no merge-blocking risk is evidenced. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mitodrummer
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one comment line to each of the 39 bootstrap-ladder rungs already on main:
Why: pkgmgr freezes these rungs (no version-bump PRs, no auto-fix, no digest proposals). Until now that relied only on a hand-kept list in pkgmgr-rs, and a missed entry is how #769 happened. With the marker the rung declares it itself (pkgmgr-rs#904/#907). The GHC and JVM ladders (#774, #775) already carry it. Marking these keeps pkgmgr's marker-vs-list drift warning quiet, since the list stays as a backstop.
No rebuilds, no behaviour change: it's a Nickel comment, so it isn't evaluated and isn't in minimal's spec hash. Checked: no rung uses its directory or build.ncl as a
Localinput. Placed just abovelet version(or at line 1 when there is none). Validated with pkgmgr's parser rules: 39/39 well-formed, none inside a multi-line string. The attr form (attrs.bootstrap_rung) replaces this once gominimal/minimal#1752 lands and the evaluators roll.🤖 Generated with Claude Code
Summary by CodeRabbit