Repository navigation
next: pin sharp 0.35.4 (0.35.5 needs libvips 8.18.7; fixes FTBFS after #764) - #773
bryan-minimal wants to merge 1 commit into
Conversation
next's build.sh ran an unpinned `npm install sharp node-addon-api node-gyp`. sharp 0.35.5 (published 2026-09-27) raised its floor to libvips >=8.18.7, so the rebuild triggered by the pnpm 12.5.1 bump (#764) FTBFS on both arches against our libvips 8.18.6: common.h:23: #error "libvips version 8.18.7+ is required" Pin sharp to 0.35.4 (satisfies next 16.3.6's ^0.35.4 and libvips >=8.18.6), and node-addon-api/node-gyp to the versions that resolved. Exact pins also make the build reproducible. Follow-up: libvips 8.18.7, then SHARP_VERSION=0.35.5. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: gominimal/pkgs/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe Next.js build script now installs fixed versions of sharp, node-addon-api, and node-gyp. Comments describe the compatibility of sharp 0.35.4 with the build’s libvips version. ChangesNext.js build dependencies
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The version pins address the reported build compatibility problem. No actionable issue is established, though CI and buildbot should confirm the build. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
nextFTBFS on both arches since the pnpm 12.5.1 bump (#764) rebuilt it:Cause: not pnpm.
packages/next/build.shinstalls sharp unpinned (npm install --ignore-scripts sharp node-addon-api node-gyp) and source-builds it against our system libvips. sharp 0.35.5 was published 2026-09-27 13:46 UTC and raisedconfig.libvipsfrom>=8.18.6to>=8.18.7; we ship libvips 8.18.6. #764 was tested on 09-24/25, when 0.35.4 was the newest release, so the same build passed then. Any rebuild ofnextsince 09-27 afternoon would have failed.Fix: pin exact versions:
sharp@0.35.4(satisfies next 16.3.6's ownoptionalDependencies.sharp: ^0.35.4and accepts libvips 8.18.6),node-addon-api@8.9.2,node-gyp@13.0.2(what the failing build resolved; both compiled fine up to the libvips check). Exact pins are also what the reproducibility rules require: an unpinned install can't produce byte-identical builds. A comment tiesSHARP_VERSIONtopackages/libvips.Follow-up (separate PR): libvips 8.18.7 is out (2026-09-26); bump it, then
SHARP_VERSION=0.35.5.Unresolved / needs a reviewer: not built locally (no local builds); this PR's CI and buildbot are the verification. The existing
sharp_uses_system_libvipstest (expects vips8.18.x) is unchanged and still holds.🤖 Generated with Claude Code
Summary by CodeRabbit