Skip to content

Fix open CodeQL findings - #391

Merged
goldmar merged 2 commits into
mainfrom
agent/fix-code-scanning-alerts
Aug 2, 2026
Merged

Fix open CodeQL findings#391
goldmar merged 2 commits into
mainfrom
agent/fix-code-scanning-alerts

Conversation

@goldmar

@goldmar goldmar commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace polynomial trailing-slash normalization with a deterministic linear scan
  • replace shell-backed executable discovery with direct PATH and executable-file checks
  • add focused regressions for adversarial slash input and shell-looking command names

Root causes

resolveAgentChannel applied an ambiguous repeated-slash regular expression to configuration-backed path strings, allowing quadratic backtracking on non-matching long inputs. The Telegram proof doctor also used sh -c for executable discovery; although the candidate command was passed positionally, the shell boundary caused environment-derived executable paths to reach a shell-command sink.

The remaining three alerts were fixed test-fixture URLs used only in string-formatting assertions. They have no production reachability, URL parsing, network request, redirect, or trust-boundary role and were individually dismissed as false positives with that justification.

Validation

  • pnpm test:file tests/config.test.ts tests/oca-codex-telegram-proof.test.ts
  • pnpm verify
  • pnpm check-plugin-security
  • pnpm audit --prod
  • git diff --check

Operational boundary

This PR does not merge itself, modify main, deploy, release, or change runtime configuration.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

Bundle Size Report

Runtime file Size
dist/chunks/agent-pr.js 0.6 KB
dist/chunks/chunk.js 110.2 KB
dist/chunks/npm-release-client.js 0.2 KB
dist/index.js 422.1 KB
Total 533.1 KB
Limit Status
600.0 KB ✅ Within limit

Complete bundle is within the 600.0 KB limit.

@goldmar

goldmar commented Aug 2, 2026

Copy link
Copy Markdown
Owner Author

🔄 New commits pushed

2 new commits (+978 / -98)

Latest commits:

7dab7e1 Fix open CodeQL findings (Mark Goldenstein)
8210577 Fix plan approval resume and worktree lifecycle races (#390) (Mark)


🤖 openclaw-code-agent

@goldmar
goldmar marked this pull request as ready for review August 2, 2026 01:39
@goldmar

goldmar commented Aug 2, 2026

Copy link
Copy Markdown
Owner Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7dab7e1638

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/e2e/oca-codex-telegram-proof.ts Outdated
@goldmar

goldmar commented Aug 2, 2026

Copy link
Copy Markdown
Owner Author

🔄 New commits pushed

3 new commits (+999 / -100)

Latest commits:

03c99c1 Preserve empty PATH lookup entries (Mark Goldenstein)
7dab7e1 Fix open CodeQL findings (Mark Goldenstein)
8210577 Fix plan approval resume and worktree lifecycle races (#390) (Mark)


🤖 openclaw-code-agent

@goldmar

goldmar commented Aug 2, 2026

Copy link
Copy Markdown
Owner Author

@codex review again

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 03c99c108b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@goldmar
goldmar merged commit 4dccc87 into main Aug 2, 2026
10 checks passed
@goldmar
goldmar deleted the agent/fix-code-scanning-alerts branch August 2, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant