gok vm: use cpu:host instead of named variants#100
Open
damdo wants to merge 1 commit intogokrazy:mainfrom
Open
gok vm: use cpu:host instead of named variants#100damdo wants to merge 1 commit intogokrazy:mainfrom
damdo wants to merge 1 commit intogokrazy:mainfrom
Conversation
I was seeing this error when running `gok vm` from macos. ``` qemu-system-aarch64: Invalid CPU model: cortex-a72 ``` Which is due this series of qemu changes: https://patchew.org/QEMU/20231129042012.277831-1-gshan@redhat.com/#:~:text=157%20deletions(%2D)-,%5BPATCH%20v8%200%2F9%5D%20Unified%20CPU%20type%20check,been%20queued%20to%20the%20branch. This is what the docs state: A note about CPU models and KVM Named CPU models generally do not work with KVM. There are a few cases that do work, e.g. using the named CPU model cortex-a57 with KVM on a seattle host, but mostly if KVM is enabled the host CPU type must be used. This means the guest is provided all the same CPU features as the host CPU type has. And, for this reason, the host CPU type should enable all CPU features that the host has by default. Indeed it’s even a bit strange to allow disabling CPU features that the host has when using the host CPU type, but in the absence of CPU models it’s the best we can do if we want to launch guests without all the host’s CPU features enabled. This validation was ignored in qemu 9 and made strict in 10 ref: https://www.qemu.org/docs/master/system/arm/cpu-features.html
Contributor
Author
|
cc. @stapelberg |
Contributor
Author
|
Closing and reopening to kick off testing again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was seeing this error when running
gok vmfrom macos.Which is due this series of qemu changes: https://patchew.org/QEMU/20231129042012.277831-1-gshan@redhat.com/#:~:text=157%20deletions(%2D)-,%5BPATCH%20v8%200%2F9%5D%20Unified%20CPU%20type%20check,been%20queued%20to%20the%20branch.
This is what the docs state:
A note about CPU models and KVM
Named CPU models generally do not work with KVM. There are a few cases that do work, e.g. using the named CPU model cortex-a57 with KVM on a seattle host, but mostly if KVM is enabled the host CPU type must be used. This means the guest is provided all the same CPU features as the host CPU type has. And, for this reason, the host CPU type should enable all CPU features that the host has by default. Indeed it’s even a bit strange to allow disabling CPU features that the host has when using the host CPU type, but in the absence of CPU models it’s the best we can do if we want to launch guests without all the host’s CPU features enabled.
This validation was ignored in qemu 9 and made strict in 10
ref: https://www.qemu.org/docs/master/system/arm/cpu-features.html