Supporting MatchedRequests larger than OSRM 'max_match_size'#9
Open
TNonet wants to merge 1 commit intogojuno:masterfrom
Open
Supporting MatchedRequests larger than OSRM 'max_match_size'#9TNonet wants to merge 1 commit intogojuno:masterfrom
TNonet wants to merge 1 commit intogojuno:masterfrom
Conversation
- Moved helper functions outside of BaseRequest - Implemented MatchRequestSections which iteratively calls MatchRequest - Updated testcases with non-localhost OSRM server - Added testcases for match_sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I utilized this simple module for a project of mine. However, I ran into the issue that I believe many other people face. The OSRM 'max_match_size' setting has a default value of 100. Therefore for longer sequences of points, I implemented a new request which properly sections and cuts a sequence of coordinates, radiuses, and timestamps, and submits them as a sequence of MatchRequests. However, I decided against post-processing these separate match requests and allowing the user to analyze them as needed.