Fix crash on Incoming Message class - #83
Merged
AbhijeetMallick merged 2 commits intoAug 10, 2026
Merged
Conversation
rishabhabbu-ctrl
approved these changes
Aug 6, 2026
deepanshu42
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
On devices where the SQLite message store fails to initialize, the app falls back to an in-memory store. When MQTTCourierClient.destroy() attempts to delete pending messages using NSBatchDeleteRequest, it crashes with NSInternalInconsistencyException: "Unknown command type ". This is because NSBatch*Request is only supported on SQLite stores, not in-memory stores.
Solution:
Added useSafeDeleteForNonSQLiteStore flag (defaults to true) to IncomingMessagePersistence
Track which store type was actually initialized (resolvedStoreType)
Route deletion based on store type:
SQLite store → use fast NSBatchDeleteRequest (unchanged)
In-memory store → use safe fetch-and-delete loop (works on all store types)
Flag can be set to false to revert to old behavior if needed