Remove hardcoded static for MQTTClientGJ - #82
Open
AbhijeetMallick wants to merge 3 commits into
Open
Conversation
Collaborator
This So With this change, when we bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MACH_O_TYPE = staticlib;from all 5 build configurations (Debug/Production/Alpha/Integration/Release) of theMQTTClientGJtarget in Courier.xcodeprojMQTTClientGJ.xcframeworkwith dynamic Mach-O binaries (device arm64 and simulator arm64/x86_64)MQTTClientGJ.podspecto 1.0.19 (matching the lockstep version bump across all other pods)c.static_framework = trueflag fromCourierMQTT,CourierMQTTChuck, andCourierProtobufpodspecs (from prior commit)Why
The prior "Distribute pods as dynamic" commit removed the static framework flag from the Swift pods, but MQTTClientGJ remained a static vendored binary. This caused trunk validation to reject
CourierMQTT1.0.19 as dynamic with a transitive static dependency, violating CocoaPods' linking rules.By making the underlying
MQTTClientGJxcframework dynamic, consumers can now choose their own linkage: dynamic consumers use defaultuse_frameworks!, static consumers adduse_frameworks! :linkage => :staticin their own Podfile.