perf: optimize Echo dispatch and add reproducible benchmarks#5
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
101 Switching Protocols.net/http, Echo, Gin, Chi, Gorilla Mux, and httprouter, including raw samples, a deterministic SVG, methodology, source provenance, and CI verification.Why
The Echo path had avoidable adapter allocations and middleware reconstruction on hot requests, while timeout work could outlive ownership of a pooled request context. Fixing those issues restores competitive performance and makes cancellation behavior deterministic.
The benchmark records seven rotated single-core samples with environment and dependency metadata. CI verifies source currentness and deterministic rendering instead of comparing machine-dependent performance or enforcing rankings.
Compatibility
Source/API, configuration, persisted-data, and minimum-Go-version compatibility are preserved. Runtime behavior changes intentionally: middleware constructors run once at registration, WebSocket middleware can reject before upgrade, and state crossing a timeout boundary must use
web.Context.Set/Getrather than the native Echo store.Validation
GOWORK=offnested-module validation.checkptrvalidation pass.make benchmark-svg-verifypasses twice with identical artifact hashes.