basis_universal: Sync with latest Git to solve more warnings#111445
basis_universal: Sync with latest Git to solve more warnings#111445Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
9e42d79 to
845f9f7
Compare
|
|
||
| #ifndef __EMSCRIPTEN__ | ||
| #if defined(__GNUC__) && !defined(__clang__) | ||
| #ifdef __GNUC__ |
There was a problem hiding this comment.
FYI @Repiteo we didn't need that change. This is a .cpp file so it's compiled in env_thirdparty with disable_warnings() so it shouldn't raise warnings for us.
The case where we get warnings from third-party code is when they're emitted by headers which we include in first-party Godot code compiled with warnings enabled. That's what -isystem etc. aimed to work around, by marking third-party headers as "system" so they don't generate internal warnings.
Anyway I proposed a fix for that one upstream too:
But I'm not including it in this PR as we don't need it, and we want to minimize the amount of patches we have to maintain downstream.
There was a problem hiding this comment.
Shoot, so it is! Must've forgot to limit my regex search to headers
|
Thanks! |
Follow-up to:
I PR'ed some additional warning fixes upstream, included here:
-Wnontrivial-memcall, clean up some unnecessary GCC-Wclass-memaccesspragmas BinomialLLC/basis_universal#404