Add [BindSharedEnum] attribute to share namespace-level enums across GDExtension classes#47
Draft
MLAcookie wants to merge 1 commit into
Draft
Add [BindSharedEnum] attribute to share namespace-level enums across GDExtension classes#47MLAcookie wants to merge 1 commit into
MLAcookie wants to merge 1 commit into
Conversation
…asses Introduce [BindSharedEnum(typeof(T))] which allows multiple Godot extension classes to register constants from the same namespace-level enum type. The enum itself needs no [BindEnum] attribute. - New BindSharedEnumAttribute (AllowMultiple, targets Class) - ClassSpecCollector extracts enum type from typeof() argument - ConstantSpecCollector.CollectShared() skips [BindEnum] check
MLAcookie
marked this pull request as ready for review
June 12, 2026 06:18
MLAcookie
marked this pull request as draft
June 12, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces
[BindSharedEnum]— a new attribute that allows namespace-level enums to be shared across multiple GDExtension[GodotClass]classes. Before, enums registered via[BindEnum]must be nested inside a[GodotClass]because the source generator only scans class members, forcing duplication when multiple extension classes need the same enum.Before (enum duplicated per class)
After (enum declared once, shared)
Compatibility
[BindEnum]on nested enums continues to work unchanged.[BindSharedEnum]only affects classes that explicitly use it.Godot.Bindings.Note
I recognize that godot-dotnet may not currently be in a phase where convenience features like this are a priority, and the
[BindEnum]pattern already covers the basic use case. If this doesn't align with the current roadmap, feel free to close without hesitation.Either way, thank you for your time reviewing this.