fix: suppress response body for HEAD requests (RFC 9110)#50
Merged
FumingPower3925 merged 1 commit intomainfrom Mar 9, 2026
Merged
fix: suppress response body for HEAD requests (RFC 9110)#50FumingPower3925 merged 1 commit intomainfrom
FumingPower3925 merged 1 commit intomainfrom
Conversation
HEAD responses must not contain a message body. The server was sending body bytes for HEAD, which corrupted subsequent keep-alive responses: the unread body data merged with the next response's status line, causing "malformed HTTP status code" errors (e.g., /testHTTP/1.1). Content-Length is still included to indicate what a GET would return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HEAD /test) concatenated with the next response's status line as a malformed status code (/testHTTP/1.1).isHEADflag toh1ResponseAdapter. When set,WriteResponseincludesContent-Length(indicating what a GET would return) but omits the body bytes.This was the root cause of the
TestConformanceMatrix/epoll/auto/BasicMethods/OPTIONSfailure in the v0.3.5 release.Test plan
go test -race ./test/conformance/...epoll/auto/BasicMethods/OPTIONSno longer fails