fix: arm64 io_uring detection and H2 flow control throughput#40
Merged
FumingPower3925 merged 2 commits intomainfrom Mar 9, 2026
Merged
fix: arm64 io_uring detection and H2 flow control throughput#40FumingPower3925 merged 2 commits intomainfrom
FumingPower3925 merged 2 commits intomainfrom
Conversation
- Replace MSG_PEEK-based protocol detection with inline detection in handleRecv, fixing 20x slowdown on arm64 where MSG_PEEK behaves differently. Detection now happens on first received data, matching epoll's approach. - Remove dead code: prepRecvPeek, udPeek, msgPeek, handlePeek. - Eliminate per-DATA-frame map allocation in FlushWindowUpdates by writing WINDOW_UPDATE frames directly while iterating pending updates. - Lower windowUpdateThreshold from 16384 to 1024 so small bodies (4KB) get timely flow control credits on multiplexed connections. - Clean up pendingStreamUpdates in DeleteStream to prevent unbounded map growth over long-lived connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two performance issues identified in official benchmarks:
MSG_PEEK-based protocol detection with inline detection inhandleRecv, eliminating arm64 kernel behavior differences. Remove dead code (prepRecvPeek,udPeek,msgPeek,handlePeek).windowUpdateThresholdfrom 16384→1024, eliminate per-DATA-frame map allocation inFlushWindowUpdates, clean up stalependingStreamUpdatesentries on stream deletion.Closes #39
Changes
engine/iouring/worker.gohandlePeek+MSG_PEEKwithdetectProtocolinsidehandleRecvengine/iouring/sqe.goprepRecvPeekengine/iouring/cqe.goudPeekconstantengine/iouring/consts.gomsgPeekconstantprotocol/h2/stream/flowcontrol.goFlushWindowUpdatesprotocol/h2/stream/manager.gopendingStreamUpdatesinDeleteStreamTest plan
GOOS=linux GOARCH=amd64 go build ./...GOOS=linux GOARCH=arm64 go build ./...go test -race ./...— all core packages pass