Repository navigation
Simplify checkpoint onboarding, deduplicate OpenUI questions, and refine Agree - #264
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Surla's browser window on a new project greeted first-time users with a multi-row navigation header, empty
AgreedandNextslots, five secondary workspace tabs, aCurrent view detailsdisclosure, and a falseNeeds you: Guide status unknown.warning whenever the coding agent connected over MCP outside a Herdr pane (herdr_mode: "available"). Once the first Change Card arrived, the user still had to click through fromChanges, and the Agree view repeated question choices and[Selected draft answer: ...]readouts between OpenUI decision cards andOpen Questions, rendered Concrete Examples twice (as static prose above editable fields), showed emptyPreserved Contract Invariants (0), scattered sevenDetailsidentifier blocks across the form, and left the confirmation button below a tall page without a direct jump to unanswered items.This change replaces the empty start state with a focused welcome card that opens the first Change Card automatically when proposed, removes the false outside-Herdr status warning, deduplicates OpenUI and form controls onto shared accessible components, and keeps the next confirmation action reachable in the top frame and mobile bottom bar.
Resulting behavior
Team,Story,Live target,Architecture,Diagnostics) into a compact keyboard-accessible Inspect menu (Escapeand outside-click dismiss with focus restoration), and centers a three-step welcome card directing the developer to describe their change in their coding agent. Whenlist_changestransitions from0to1card while viewing the empty state, Surla opens that Change Card automatically in Agree. SeparatingguideInHerdr(herdr_mode === "attached") fromherdrWorkerAvailableremoves the false"unknown"alert for coding agents attached outside Herdr while preserving real worker"unknown"and error alerts.Agreeediting: OpenUIAmbiguityChoiceCardandPolicySimulatorTablecomponents and the Agree form share a roving-tabindexChoiceGroupcomponent with arrow-key navigation and44pxmobile touch targets. When a validated OpenUI block already renders a question'sChoiceGroup,Open Questionsomits that question instead of repeating it;[Selected draft answer: ...]echoes, raw option bullets, duplicate Concrete Example prose headers, and zero-countPreserved Contract Invariants (0)are removed; and scattered technical IDs collapse into quietAgreement identifiersandTechnical identifiersdisclosures.Nextactions, plain"coding agent"wording, and preserved recovery guidance: While a Change Card needs confirmation on Agree, theNextslot (sticky in the header on desktop and docked at the bottom of the viewport on narrow screens with scroll padding) provides a direct button to focus the next unanswered question (Jump to unanswered question), focus an incomplete example field (Review example), or submit confirmation (Confirm intent). User-facing browser copy replaces internal"Guide"labels with"your coding agent"(showing"Coding agent (guide)"on Team and Open Surla Window in session recovery), while preserving unsaved drafts across conflicts and incoming revisions, local-validation versus server-request error alerts, and Build drop/stale-card recovery guidance.Verification
Verified with TypeScript typechecking,
node ui/checkpoint/build.mjs --check, Node client build tests, Go served-page and race suites, and headless Chromium journey, keyboard/focus, dark/light, and1280px/375pxlayout checks across empty onboarding,0 -> 1auto-open, OpenUI and fallback Agree flows, Team, and Build recovery.