Repository navigation
Derive default module path in init_project and simplify /surla start - #261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a developer invoked
/surlain an empty folder, the bundled/surlaskill instructed the guide to pass "the user's module path" andinit_projectdeclaredmodule_pathas a required field. As a result, the guide paused before initializing or opening the browser page and asked the user for a Go module path alongside upfront product-discovery questions in chat, turning first-use onboarding into setup work.Resulting behavior
module_pathderivation ininit_project:InitProjectPayload.module_pathis now optional (MinLength(3)retained when supplied so empty strings remain structurally invalid). Omittingmodule_pathderivesexample.com/<service>from the target folder name (lowercased ASCII letters and non-leading digits up to 48 characters, appendingsvc—clamped to 48 characters—formain, Go keywords,vNmodule-version suffixes, or reserved module path names, and falling back toexample.com/appwhen no ASCII letter is present). Passingdir: "."or omitting bothmodule_pathanddirinitializes the bound workspace folder in place; passing an explicitmodule_pathpreserves existing validation and child-directory defaults./surla:skills/surla/SKILL.mdnow instructs the guide to attach and open the browser page first, ask at most one plain question ("What would you like to build?") when the user invoked/surlawithout a goal, callinit_projectwithdir: "."immediately once a goal is given (omittingmodule_pathunless the user supplied one), and put open product questions (such as target users, policy thresholds, or edge cases) into the Change Card'sambiguitieswith concrete options so the user decides on Agree instead of answering checklists in chat.README.md,docs/HOW_IT_WORKS.md, anddocs/REFERENCE.mddescribe the simplified/surlaonboarding flow and optionalmodule_pathcontract, and.agents/skills/surla-ux-review/updates the default participant persona and moderator rubric so future studies exercise terse/surlastarts and flag unnecessary upfront questioning or derivable plumbing toil even when documented.Verification
Verified with Goa and UI bundle consistency checks (
goa gen,node ui/checkpoint/build.mjs --check, TypeScripttypecheck,go vet), table-driveninit_projectunit and HTTP/MCP boundary suites covering omittedmodule_pathderivation across workspace and child folders, keyword/main/numeric folder names, blank and shortmodule_pathrejections,cmd/surlasetup/stdio suites, and documentation link checks.