Repository navigation
fakeserver, yenc: corpus cases from the pynntp review (#166) - #17
Merged
Merged
Conversation
Reply corpus, 112 -> 123 cases: - ReplyCase.Final: Lines replace the reply after the article of POST or IHAVE (Faults.OverrideFinal); Apply and ApplyLine set it. - post-240-address-in-text, post-240-empty-brackets (accept): no message-id in the free 240 text. - hdr-msgid-row-for-range, hdr-msgid-unclosed-row, hdr-msgid-empty-row, hdr-negative-row, hdr-plus-sign-row, hdr-underscore-row, hdr-non-ascii-digit-row (error). - list-overview-fmt-empty-name (error), list-overview-fmt-padded-name (either). yenc.Corpus: broken and odd posts for decoder test suites, with the reply corpus outcome classes: stray-yend-after-block, text-after-yend, bad-crc32, bad-size, no-yend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- OVERVIEW.FMT: split the padded-name case into bare-full (error), space-before-colon and leading-space (either). - hdr-plus-sign-row is WantEither (common parsers read the right number); the 1_0 Why says it reads 10. - The 240 Why no longer claims the text holds no message-id; the two Final cases get their own comment group; Final docs say the corpus cases need a Store that allows posting. - yenc: each case gets its own Data; the stray-yend Why says yEnc 1.3 is silent; WantError for a decoder explained; tests check the =yend lines and that no two cases share Data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corpus cases for the open findings of greenbender/pynntp#166, so other client projects get the same tests. pynntp-cc-1 contributed concrete cases from the pynntp fixes.
<...>in the 240 textpost-240-address-in-text,post-240-empty-brackets(WantAccept)hdr-msgid-unclosed-row,hdr-msgid-empty-row,hdr-negative-row,hdr-underscore-row,hdr-non-ascii-digit-row(WantError);hdr-msgid-row-for-range,hdr-plus-sign-row(WantEither)list-overview-fmt-empty-name,list-overview-fmt-bare-full(WantError);list-overview-fmt-space-before-colon,list-overview-fmt-leading-space(WantEither)=yendyenc.Corpus:stray-yend-after-block, plustext-after-yend,bad-crc32,bad-size,no-yendAPI additions:
ReplyCase.Final:Linesreplace the reply after the article of POST or IHAVE (Faults.OverrideFinal).ApplyandApplyLineboth set it.yenc.Case,yenc.Corpus(),yenc.CaseByName(), using the outcome classes of the reply corpus.The reply corpus goes from 112 to 125 cases. An independent review's fixes are in (split OVERVIEW.FMT cases, softer
+1, unshared yEnc Data, Why wording). README andfakeserver/doc.goare updated.go vet ./...andgo test ./...pass.Already covered, no change needed: #157 (11 broken-211 cases) and #161 (
Faults.Trailing). Left for later: XZVER/XZHDR and XFEATURE COMPRESS GZIP in the fake server (#154, #155, #160).🤖 Generated with Claude Code