Repository navigation
Update CoW dependencies to v2.384.4 and adapt to /solve Id enum - #235
Merged
Merged
Conversation
Signed-off-by: Aryan Godara <aryangodara03@gmail.com>
Collaborator
|
Looks good to me. Short and to the point. Approving. |
ropusaurio
approved these changes
Oct 22, 2026
MartinquaXD
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the CoW services dependencies from v2.382.0 to v2.384.4 and adapts to an API change in
solvers-dtothat broke the automated bumps in #232 and #233.Changes
to_domainmapsId::AuctiontoId::SolveandId::QuotetoId::Quote.fastPathis ignored because no engine here treats fast-path quotes differently.balancer::limit_order_quoting::sellnow sends the real quote shape ("id": null, "quoteId": "1") instead of an auction id. Until now no test sent a quote-shaped request, so the parsing path that changed had no coverage. The test fails ifquoteIdis removed.Deploy safety
Drivers have sent
quoteIdon every quote since services v2.381.0, and prod drivers already run v2.384.5, so the stricter parsing won't reject live traffic.Supersedes #232 and #233.