Repository navigation
build(deps): force minimatch 11.0.3 to clear the globparts advisory - #1721
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Dependabot alert 37:
minimatch< 11.0.1has a denial of service viaglobpartsamplification (medium severity). The advisory has no patch release in the 10.x line, the fix landed in11.0.1, andminimatchis not a direct dependency: it arrives througheslint,@eslint/config-array,@typescript-eslint/typescript-estreeandglob, all of which still request^10.2.x. That is why Dependabot cannot open its own PR for it.Change
app/package.json: add anoverridesblock forcingminimatchto^11.0.3(latest). The lockfile now contains a single copy,11.0.3, replacing10.2.6.minimatchis a development-scope dependency (lint tooling andworkbox-buildpremanifest), it never ships in the bundle, and v11 declaresnode 18 || 20 || >=22, so the repo's Node 24 CI is fine.Verification
npm auditno longer lists theminimatchadvisory.npm run lintpasses with 0 errors (8 pre-existing warnings), which exerciseseslint,@typescript-eslintand their glob handling against minimatch 11.npm run buildpasses (tsc -b && vite build), which exercises theworkbox-buildpath that also pulls aminimatch.minimatchin the tree and it is11.0.3.The remaining
npm auditfindings (deepmerge,globand two others) are pre-existing, unrelated to this advisory and left untouched on purpose.Closes #1720