Repository navigation
feat(modules): handle the config_backup command from NetPulse (#553) - #554
Merged
Merged
Conversation
Create a fresh snapshot (CreateSnapshot) and push it through the existing PushLatestSnapshot path when the embedded agent receives the config_backup SSE event. Best-effort: failures go to the log. Closes #553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetPulse now offers a standalone "Backup config" action per unit (gnacho/netpulse#1462): the server sends a
config_backupSSE command and the snapshot itself is agent-side. This wires the embedder side.New SSE event handled by the embedded agent through the
OnConfigBackuphook added in agent v1.5.6. The handler creates a fresh snapshot with the existingCreateSnapshotand pushes it to NetPulse through the existingPushLatestSnapshotpath (push config + executor token). Failures (push not configured, push error) go to the log: from the server it is a best-effort action, same posture as the remote self-update reporting before #549.CreateAndPushSnapshotkeeps both steps injectable so the behaviour is testable without uci on the build host.Closes #553