Repository navigation
fix(wifi): suggest distinct per-band names when unchecking unify - #542
Merged
Merged
Conversation
Grouping is derived from SSID equality, so unchecking the toggle without renaming left the bands grouped and the toggle re-checked on reopen: a silent no-op that read as a failure (#541). Pre-fill base and base-5g/-6g suggestions when every per-band name is still identical (never over user edits, collision-checked against other networks), and promote the identical-names banner from info to warning. Closes #541
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #541.
Band grouping is derived from SSID equality, so unchecking "Unify bands" and saving without renaming the bands sent an edit with no effective change: the save reported success, the group still existed, and the toggle came back checked on reopen. It read as a failure.
Changes:
basefor 2.4 GHz,base-5g/base-6gfor the rest). User edits are never overwritten; names already used by other networks on the device get a-2suffix; 32-char SSID limit respected.Verification: tsc clean, build OK,
go test ./...green (8 packages), Playwright checks against a local instance (pre-fill yields distinct names, toggle cycling stays stable, manual identical names show the warning banner), live previews0.76.99-541unifydeployed on two test routers (mipsle + arm64) with panels healthy.