Repository navigation
fix: ledger index migration crash on upgrade and project icon fallback - #283
Merged
Merged
Conversation
v2.6.44 shipped the index in the SCHEMA template, which runs before migrateSchema; on existing databases the table has no decision_id yet, so startup crash-looped with SQLITE_ERROR. Create it in migrateSchema instead (idempotent, covers fresh and migrated installs) and add a regression test asserting SCHEMA never contains that index.
Unknown stored names (e.g. folder from old installs) rendered as raw overlapping text; legacy emoji values still render as text, anything else falls back to a neutral folder icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, one of them urgent for the v2.6.44 release:
fix(server): v2.6.44 shipped the new gam_points_ledger index in the SCHEMA template, which runs before migrateSchema. On existing databases the table has no decision_id yet, so upgrading crash-loops at startup with SQLITE_ERROR: no such column: decision_id. The index now lives in migrateSchema (idempotent, covers fresh and migrated installs), with a regression test asserting the SCHEMA never contains that index. Fresh installs were never affected.
fix(app): projects whose stored icon name is not in the catalog (e.g. folder from old installs) rendered the raw name as overlapping text. Unknown names now fall back to a neutral folder icon; legacy emoji values still render as text.
Verified: server suite 291/291 (incl. the ledger migration rebuild preserving task rows and still awarding task points), build and lint clean, and a Playwright check of the three icon cases (unknown name, known icon, legacy emoji).
Closes #272, closes #282