Fix KeyError during artist download pagination#277
Merged
glomatico merged 1 commit intoglomatico:mainfrom Mar 5, 2026
Merged
Conversation
Contributor
Author
|
I encountered this issue. this fix is made by AI. test url: |
glomatico
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix KeyError during artist download pagination
Problem
When using artist download options like
--artist-auto-select all-albumson artists with a large number of releases (triggering the API pagination logic), the downloader would crash with aKeyError: 'id'.This was caused by the code incorrectly extending the data list with the entire response dictionary (which contains data and
nextkeys) instead of extracting and extending with the nested data list. When the subsequent loop tried to readalbum_metadata["id"]from that dictionary object, it failed.Solution
Replaced the erroneous list comprehension with an explicit
async forloop that correctly extends the results withextended_data["data"].This change ensures only album-like objects are in the list and makes the logic consistent with similar pagination handling found elsewhere in the codebase (e.g., in get_collection_download_items).
Testing
Verified by running
gamdlon an artist with a large number of singles/albums (e.g., Megan Nicole).KeyError: 'id'once pagination was triggered.