Repository navigation
Conversation
u70b3
force-pushed
the
fix/pr2185-p0-overwrite-issues
branch
2 times, most recently
from
July 5, 2026 09:02
1a37caf to
7d61df8
Compare
…schema/spec on overwrite
u70b3
force-pushed
the
fix/pr2185-p0-overwrite-issues
branch
from
July 5, 2026 09:21
7d61df8 to
603d071
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two overwrite correctness bugs in the
OverwriteActionCoW delete support from apache#2185:Drop already-
Deletedentries on rewrite —OverwriteOperation::rewrite_manifestpreviously sent onlyentry.is_alive() && deleted_file_paths.contains(...)throughadd_deleted_entry; entries already markedManifestStatus::Deletedfell through toadd_existing_entry, flipping them back toExisting. Nowif !entry.is_alive() { continue; }drops already-Deleted entries so their deletion record stays intact in the prior snapshot.Regression test:
test_overwrite_preserves_previously_deleted_entries(asserts the previously-Deleted entry does not reappear in the rewritten manifest; the newly deleted entry isDeleted; unrelated alive entries stay alive).Use the original manifest's schema / partition spec on rewrite —
rewrite_manifestpreviously built theManifestWriterBuilderwithtable.metadata().current_schema()anddefault_partition_spec(), which after schema/partition evolution writes a manifest whose schema-id / partition-spec-id don't match the original entries. Now usesmanifest.metadata().schemaandmanifest.metadata().partition_spec.Regression test:
test_overwrite_rewritten_manifest_preserves_original_partition_spec.Tests
cargo test -p iceberg transaction::overwrite --lib→ 7 passed.transaction::append --lib→ 7 passed.cc @glitchy