Repository navigation
Avoid multiple cryptography dependencies - #78
Merged
Merged
Conversation
Rustls uses aws-lc-rs by default, while rcgen is still using ring as default. Similarly, x509-parser w/ the base verification feature uses ring, but since this feature isn't in use we can drop it as opposed to switching to the aws-lc-rs backed verification feature. Instead of having a mix of both ring and aws-lc-rs, this commit standardizes on aws-lc-rs throughout.
Of the form:
```
warning: redundant reference in `format!` argument
--> src/output/terminal.rs:98:41
|
98 | format!("{}{}{}", colors::CYAN, &empty, colors::RESET)
| ^^^^^^ help: remove the redundant `&`: `empty`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#useless_borrows_in_formatting
= note: `#[warn(clippy::useless_borrows_in_formatting)]` on by default
```
gdsks-dev
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Interesting project! I have no love for the
opensslCLI and it was nice to see you usingrustlsfor a modern replacement :-)What does this PR do?
Previously
sslxbuilds used bothringandaws-lc-rsdue to a combination of upstream dependency features & an explicitringdependency for SHA256.There was a comment in
Cargo.tomlthat suggested thatringwas already brought in viarustls, but that hasn't been an accurate description of the default Rustls cryptography provider since 0.23.0:sslx/Cargo.toml
Lines 39 to 40 in a89969b
I think standardizing on
aws-lc-rsthroughout is the best choice. It's drop-in compatible for theringAPIs you were already using, it has post-quantum algorithm support, it receives regular updates, it has the best performance, and isn't self-declared as experimental. If you'd prefer to standardize onringit would be possible to write a similar PR adjusting features in the inverse direction to arrive at justringand noaws-lc-rsbut I wouldn't personally recommend that.How to test
You can use
cargo treeto verify the before/after state.Before,
ringwas being brought in bysslx(for SHA256),rcgen(by its default features), andx509-parser(via theverifyfeature that wasn't actually used in-tree AFAICT).Afterwards, only
aws-lc-rsis present:Checklist
cargo testpassescargo clippycleancargo fmtappliedI tacked on two extra commits to fix
cargo fmtandcargo clippy.