Repository navigation
fix(github): reduce merged GraphQL batch size to avoid resource limits - #3559
Merged
Merged
Conversation
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enriching notifications merges up to 100 notifications into one GraphQL query. Each entry pulls nested connections (labels, comments, replies). With larger inboxes, GitHub rejects the whole batch with
Resource limits for this query exceeded, and none of the notifications in it get enriched.Change
Reduce
GITHUB_API_MERGE_BATCH_SIZEfrom 100 to 25 and update the doc comment.Testing
pnpm vitest run src/renderer/utils/forges/github: 418 tests pass.Follow-up
The limit is undocumented and depends on how much each notification pulls in, not just how many there are. Splitting the batch in half and retrying on this error would be more robust.