Repository navigation
fix(a11y): accessible names for help buttons and scope status icons - #3558
Merged
Merged
Conversation
Help buttons announced their internal id (e.g. "tooltip-search"); they now read "Help: <label>". Scope status icons were hidden from assistive tech, so granted/missing was conveyed by colour alone; they now carry a label such as "repo missing". Tests query by role instead of test ID.
|
setchy
added a commit
that referenced
this pull request
Oct 29, 2026
Resolve conflicts with #3449, #3557, #3558 and the metric pill changes: keep main's structure (device-flow wrapper, custom OAuth app, removed test IDs, chevron directions) and wrap its strings for translation. Translate the screens main added since this branch was cut (DeviceFlowAuthorize, LoginWithCustomOAuthApp, device-flow start errors, ScopeStatusIcon, HelpPopover) and regenerate en.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HelpPopovernow takes alabeland reads "Help: ".aria-hidden, so granted/missing was conveyed by colour alone.ScopeStatusIconnow has an accessible name (e.g. "repo missing"); thewithTestIdprop is removed.Follow-up to #3510 / #3557.